kasakrisz commented on code in PR #5370:
URL: https://github.com/apache/hive/pull/5370#discussion_r1694676565
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java:
##########
@@ -79,7 +79,7 @@ public void initialize(HiveConf hiveConf) {
||
postExecHooks.contains("org.apache.hadoop.hive.ql.hooks.PostExecutePrinter")
||
postExecHooks.contains("org.apache.hadoop.hive.ql.hooks.LineageLogger")
|| postExecHooks.contains("org.apache.atlas.hive.hook.HiveHook")) {
- transformations.add(new Generator(postExecHooks));
+ transformations.add(Generator.fromConf(hiveConf));
Review Comment:
`postExecHooks` also calculated at every query execution:
https://github.com/apache/hive/blob/09553fca66ff69ff870c8a181750b70d81a8640e/ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java#L75-L77
I think this should be addressed in a follow-up only if this is bottleneck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
