kasakrisz commented on code in PR #5370:
URL: https://github.com/apache/hive/pull/5370#discussion_r1694698948
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3865,6 +3865,8 @@ public static enum ConfVars {
"get old behavior, if desired. See, test-case in patch for
HIVE-6689."),
HIVE_LINEAGE_INFO("hive.lineage.hook.info.enabled", false,
"Whether Hive provides lineage information to hooks."),
+ HIVE_LINEAGE_STATEMENT_FILTER("hive.lineage.statement.filter", "All",
Review Comment:
The comparison is not case sensitive to make this more felxible
```
if (ALL.equalsIgnoreCase(valueText)) {
```
```
if (NONE.equalsIgnoreCase(valueText)) {
```
```
HiveOperation enumValue = EnumUtils.getEnumIgnoreCase(HiveOperation.class,
valueText);
```
I added an upper case default value because other values coming from
HiveOperation are in upper case. There are other configs with upper case values
so I think it is not an exception.
I also added the missing description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
