soumyakanti3578 commented on code in PR #5384: URL: https://github.com/apache/hive/pull/5384#discussion_r1704430191
########## ql/src/test/queries/clientpositive/filter_emptyliteral.q: ########## @@ -0,0 +1,3 @@ +create table employee(name varchar(255), id int); + +explain cbo SELECT id FROM employee where name = ''; Review Comment: Please add another test for `char` for completeness. Otherwise, looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
