ramesh0201 commented on PR #5384:
URL: https://github.com/apache/hive/pull/5384#issuecomment-2273730639
@soumyakanti3578
Thanks for the initial review. I have tested the patch with empty literal
filters on char and varchar column.
Empty literal filter on char column appends space on the empty literal
before RexNode to ExprNode conversion. So by the time of conversion we are not
dealing with a empty string.
In the case of empty literal filter on varchar column, the literal is
identified as a char and then has cast to varchar on top of it. Like
cast(''(char type) as varchar). So the switch case in the
toExprNodeConstantDesc for the varchar will never receive a empty literal and
hence the fix for the char case alone will suffice.
Please let me know your thoughts and also re-review the latest patch. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
