saihemanth-cloudera commented on code in PR #5275:
URL: https://github.com/apache/hive/pull/5275#discussion_r1723641945
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -8884,6 +8884,30 @@ public List<String> get_functions(String dbName, String
pattern)
return funcNames;
}
+ @Override
+ public GetFunctionsResponse get_functions_req(GetFunctionsRequest req)
+ throws MetaException {
+ startFunction("get_functions", ": db=" + req.getDbName()
+ + " pat=" + req.getPattern());
+
+ RawStore ms = getMS();
+ Exception ex = null;
+ List<Function> funcs = null;
+ try {
+ funcs = ms.getFunctionsRequest(req.getCatalogName(), req.getDbName(),
Review Comment:
ack
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -3005,9 +3004,19 @@ Function getFunction(String catName, String dbName,
String funcName)
* @throws MetaException error accessing the RDBMS
* @throws TException thrift transport error
*/
+ @Deprecated
List<String> getFunctions(String dbName, String pattern)
throws MetaException, TException;
+ /**
+ * Get all functions matching a pattern
+ * @param dbName database name.
+ * @param pattern to match. This is a java regex pattern.
+ * @throws MetaException error accessing the RDBMS
+ * @throws TException thrift transport error
+ */
+ GetFunctionsResponse getFunctionsRequest(String dbName, String pattern)
Review Comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
