saihemanth-cloudera commented on code in PR #5275: URL: https://github.com/apache/hive/pull/5275#discussion_r1722262987
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ########## @@ -8884,6 +8884,30 @@ public List<String> get_functions(String dbName, String pattern) return funcNames; } + @Override + public GetFunctionsResponse get_functions_in_db(GetFunctionsRequest req) + throws MetaException { + startFunction("get_functions", ": db=" + req.getDbName() + + " pat=" + req.getPattern()); + + RawStore ms = getMS(); + Exception ex = null; + List<Function> funcNames = null; Review Comment: ack ########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java: ########## @@ -8884,6 +8884,30 @@ public List<String> get_functions(String dbName, String pattern) return funcNames; } + @Override + public GetFunctionsResponse get_functions_in_db(GetFunctionsRequest req) + throws MetaException { + startFunction("get_functions", ": db=" + req.getDbName() + + " pat=" + req.getPattern()); + + RawStore ms = getMS(); + Exception ex = null; + List<Function> funcNames = null; + + try { + funcNames = ms.getFunctionsInDb(req.getCatalogName(), req.getDbName(), req.getPattern()); Review Comment: ack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org