tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1741679492
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CheckResult.java:
##########
@@ -95,22 +103,27 @@ public Set<PartitionResult> getPartitionsNotInMs() {
* @param partitionsNotInMs
* a list of partitions not found in the metastore
*/
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP2", justification =
"intended_to_do")
public void setPartitionsNotInMs(Set<PartitionResult> partitionsNotInMs) {
this.partitionsNotInMs = partitionsNotInMs;
}
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP", justification =
"intended_to_do")
public Set<PartitionResult> getExpiredPartitions() {
return expiredPartitions;
}
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP2", justification =
"intended_to_do")
public void setExpiredPartitions(final Set<PartitionResult>
expiredPartitions) {
this.expiredPartitions = expiredPartitions;
}
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP", justification =
"intended_to_do")
Review Comment:
We had upgraded spotbugs-maven-plugin from 4.0.0 to 4.5.0.0 for
compatibility with JDK17.
Each upgrade of this plugin enhances the rules for finding the potential
bugs and a major enhancement was in 4.3.0 release where the change was
`MS_EXPOSE_REP and EI_EXPOSE_REP are now reported for code returning a
reference to a mutable object indirectly (e.g. via a local variable)`
Due to this change, a lot of new bugs arised in our codebase and since there
is a complete different initiative to fix these bugs as part of
[HIVE-23613](https://issues.apache.org/jira/browse/HIVE-23613) , for jdk17
migration we have suppressed these new warnings with intended_to_do token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
