tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1742331463
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDateFormat.java:
##########
@@ -166,7 +166,7 @@ public void testNullFmt() throws HiveException {
public void testWrongFmt() throws HiveException {
GenericUDFDateFormat udf = new GenericUDFDateFormat();
ObjectInspector valueOI0 =
PrimitiveObjectInspectorFactory.writableStringObjectInspector;
- Text fmtText = new Text("B");
+ Text fmtText = new Text("C");
// 'B' is defined as a pattern in jdk17 to represent
period-of-day, changing it to pattern 'C' having no definition in jdk17
Review Comment:
The extra spaces came in here due to the comment i had added for explaining
the change. Removing the comment from file to make it cleaner & adding it as
comment here for future review reference. 😅
Comment: ` 'B' is defined as a pattern in jdk17 to represent period-of-day,
changing it to pattern 'C' having no definition in jdk17`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
