zhangbutao commented on code in PR #5444:
URL: https://github.com/apache/hive/pull/5444#discussion_r1756099733
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/histogram/KllHistogramEstimator.java:
##########
@@ -30,11 +30,11 @@ public class KllHistogramEstimator {
private final KllFloatsSketch kll;
KllHistogramEstimator() {
- this.kll = new KllFloatsSketch();
+ this.kll = KllFloatsSketch.newHeapInstance();
Review Comment:
In this commit:
https://github.com/apache/datasketches-java/commit/f3d80294e1e34278d1cd7a46071929ae267d633c#diff-255436ca709c4ad22450438c6b07cb84771cbb9694ebaec9b15ab201f8f03673
KllFloatsSketch was changed to `abstract`. Use
`KllFloatsSketch.newHeapInstance()` to get the instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
