zhangbutao commented on code in PR #5444:
URL: https://github.com/apache/hive/pull/5444#discussion_r1757937280
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/FilterSelectivityEstimator.java:
##########
@@ -511,7 +511,7 @@ private static double rangedSelectivity(KllFloatsSketch
kll, float val1, float v
* @return the selectivity of a predicate "column > value" in the range
[0, 1]
*/
public static double greaterThanSelectivity(KllFloatsSketch kll, float
value) {
- float max = kll.getMaxValue();
+ float max = kll.getMaxItem();
Review Comment:
I didn't do much research, but I think it is ok.
To be honest, it's hard to explore the reasons for some commits of apache
datasketches. Apache datasketches often doesn't give more details about its
commit. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
