linghengqian commented on code in PR #5375: URL: https://github.com/apache/hive/pull/5375#discussion_r1797720834
########## data/conf/hive-log4j2.properties: ########## @@ -14,9 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -status = INFO Review Comment: - `status` is only used to set the output of log4j2's internal log. Its default value is `WARN`. Setting `status` to `INFO` actually masks the deprecated property warning of log4j2. When I looked at `mvn test -Dtest=TestHplsqlLocal`, I found that the assertion of the unit test is essentially matching the predefined output log file. In this case, there is actually no need to change the value of `status`. And starting from log4j2 2.24.0, the status attribute in the Configuration element has been deprecated, refer to https://logging.apache.org/log4j/2.x/manual/status-logger.html#config . - The `log4j.debug` system property directly overrides changes to the `status` property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
