linghengqian commented on code in PR #5375:
URL: https://github.com/apache/hive/pull/5375#discussion_r1800714603


##########
pom.xml:
##########
@@ -1791,7 +1791,6 @@
             
<log4j.configurationFile>${test.log4j.scheme}${test.conf.dir}/hive-log4j2.properties</log4j.configurationFile>
             
<hive.test.console.log.level>${test.console.log.level}</hive.test.console.log.level>
             <hive.cluster.id>hive-test-cluster-id-cli</hive.cluster.id>
-            <log4j.debug>true</log4j.debug>

Review Comment:
   log4j.debug actually has no effect in previous versions of log4j2. Setting 
it to `true` will also make it impossible to override changes to log4j2's 
internal behavior through the command line. In log4j 2.24.0, which strengthens 
the role of log4j.debug, setting log4j.debug will cause the configuration of 
log4j2's internal log in the log4j2 properties file to become invalid. 
log4j.debug should usually only be called from the command line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to