armitage420 commented on code in PR #5205: URL: https://github.com/apache/hive/pull/5205#discussion_r1825866667
########## service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java: ########## @@ -44,14 +44,12 @@ * Test CLI service with a retrying client. All tests should pass. This is to validate that calls * are transferred successfully. */ -public class TestRetryingThriftCLIServiceClient { +public class TestRetryingThriftCLIServiceClient extends AbstractThriftCLITest { protected static ThriftCLIService service; - private HiveConf hiveConf; - private HiveServer2 server; - @Before - public void init() { - hiveConf = new HiveConf(); + @BeforeClass + public void init() throws Exception { Review Comment: @deniskuzZ I wanted to fix the commits along with this change. Regarding the no valid location, it seems like it is happening post enabling tez as the default execution engine in [HIVE-27972](https://issues.apache.org/jira/browse/HIVE-27972). Also, I can pick the redundant throws and thread sleep issues soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org