armitage420 commented on code in PR #5205:
URL: https://github.com/apache/hive/pull/5205#discussion_r1839697939
##########
service/src/test/org/apache/hive/service/cli/TestRetryingThriftCLIServiceClient.java:
##########
@@ -44,14 +44,12 @@
* Test CLI service with a retrying client. All tests should pass. This is to
validate that calls
* are transferred successfully.
*/
-public class TestRetryingThriftCLIServiceClient {
+public class TestRetryingThriftCLIServiceClient extends AbstractThriftCLITest {
protected static ThriftCLIService service;
- private HiveConf hiveConf;
- private HiveServer2 server;
- @Before
- public void init() {
- hiveConf = new HiveConf();
+ @BeforeClass
+ public void init() throws Exception {
Review Comment:
@deniskuzZ Thanks so much for your help! I did try setting the jar
directory. I also came across some more errors that needed to be fixed.
Although, initializing hiveconf with HiveConfForTest seemed like a cleaner
approach. And now it is working in my local as well!
Created [HIVE-28602](https://issues.apache.org/jira/browse/HIVE-28602) for
redundant exception throws and thread.sleep.
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
