abstractdog commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1833177833
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -1072,7 +1073,9 @@ public Allocator getAllocator() {
@Override
public void close() throws IOException {
- // Noop: orcDataReaderRef is owned by the parent object
+ if (orcReader != null){
Review Comment:
okay, uploaded new commit
https://github.com/apache/hive/pull/5534/commits/df13c21aced3839aa3b532bdf5159203f4bd7610
tested on cluster, problem solved: no sockets left behind, query passed that
has failed without the patch
looks like the cleanupReaders method is called as expected, so closing the
orcReader there works
need to note that there were 2 different stacks where the leakage happened,
@harishjp is attaching them to jira as we speak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
