abstractdog commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1833854760
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -531,6 +531,15 @@ private void cleanupReaders() {
// Ignore.
}
}
+
+ if (orcReader != null) {
Review Comment:
it looks like we close everything else in cleanupReaders, which is called
from performDataRead
by closing this, are you suspecting a failure, or a perf degradation
(meaning that this reader will be reopened any time if it's found to be null)
(let me check the lifecycle of the OrcEncodedDataReader in the meantime more
thoroughly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
