deniskuzZ commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1834503335
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -838,6 +847,7 @@ private void ensureRawDataReader(boolean isOpen) throws
IOException {
if (!isRawDataReaderOpen && isOpen) {
long startTime = counters.startTimeCounter();
rawDataReader.open();
+ isRawDataReaderOpen = true;
Review Comment:
should we close the reader regardless of `isRawDataReaderOpen`?
say somewhere in the middle of open we failed and pool.
would be better if we expose IsOpen() method in `LlapDataReader` interface
and drop the `isRawDataReaderOpen`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
