abstractdog commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1834600122
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -531,6 +531,15 @@ private void cleanupReaders() {
// Ignore.
}
}
+
+ if (orcReader != null) {
Review Comment:
yeah, I was thinking about making all the readers implement Closeable and
use IOUtils.closeQuietly, so the question is where to stop refactoring the
messy thing now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
