harishjp commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1834639249
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -523,14 +528,17 @@ private void cleanupReaders() {
// Ignore.
}
}
- if (rawDataReader != null && isRawDataReaderOpen) {
+ if (rawDataReader != null) {
try {
rawDataReader.close();
rawDataReader = null;
} catch (IOException ex) {
// Ignore.
}
}
+
+ IOUtils.closeQuietly(orcReader);
Review Comment:
This would log only on close failures, which I'm assuming should not happen
normally. I would set the level to be as high as WARN for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
