deniskuzZ commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1834693550
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -523,14 +528,17 @@ private void cleanupReaders() {
// Ignore.
}
}
- if (rawDataReader != null && isRawDataReaderOpen) {
+ if (rawDataReader != null) {
Review Comment:
can we add the Closable interface
````
public interface EncodedReader extends Closeable {
public interface LlapDataReader extends Closeable, Cloneable {
````
and do
````
try {
IOUtils.close(stripeReader, rawDataReader, orcReader);
} catch (IOExceptionList e) {
LOG.warn(e.getMessage());
}
stripeReader = null;
rawDataReader = null;
orcReader = null;
````
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -523,14 +528,17 @@ private void cleanupReaders() {
// Ignore.
}
}
- if (rawDataReader != null && isRawDataReaderOpen) {
+ if (rawDataReader != null) {
try {
rawDataReader.close();
rawDataReader = null;
} catch (IOException ex) {
// Ignore.
}
}
+
+ IOUtils.closeQuietly(orcReader);
Review Comment:
there is overloaded `closeQuietly` with the consumer
````
IOUtils.closeQuietly(reader, e -> LOG.warn(e.getMessage()));
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
