harishjp commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1837189008
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -523,14 +528,17 @@ private void cleanupReaders() {
// Ignore.
}
}
- if (rawDataReader != null && isRawDataReaderOpen) {
+ if (rawDataReader != null) {
Review Comment:
Nice thanks! Done, changed all other classes/interfaces to be Closeable too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
