harishjp commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1837268847
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -276,11 +275,20 @@ public void unpause() {
@Override
protected Void callInternal() throws IOException, InterruptedException {
- return ugi.doAs(new PrivilegedExceptionAction<Void>() {
- @Override
- public Void run() throws Exception {
- return performDataRead();
+ return ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
+ long startTime = counters.startTimeCounter();
+ try {
+ performDataRead();
+ consumer.setDone();
Review Comment:
There are way too many return and anyone trying changing code should
remember to do this correctly. This code refactors all the different call site
and unifies handling error, timing and trace to just one place. Now if you see
performDataRead is much much simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
