deniskuzZ commented on code in PR #5534: URL: https://github.com/apache/hive/pull/5534#discussion_r1837299987
########## llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java: ########## @@ -531,6 +531,15 @@ private void cleanupReaders() { // Ignore. } } + + if (orcReader != null) { Review Comment: why do you need new state? there won't be 2 concurrent threads, just close the reader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org