harishjp commented on code in PR #5534:
URL: https://github.com/apache/hive/pull/5534#discussion_r1837312634
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -516,21 +471,13 @@ private static Object
determineFileId(Supplier<FileSystem> fsSupplier, FileSplit
* Closes the stripe readers (on error).
*/
private void cleanupReaders() {
- if (stripeReader != null) {
- try {
- stripeReader.close();
- } catch (IOException ex) {
- // Ignore.
- }
- }
- if (rawDataReader != null && isRawDataReaderOpen) {
- try {
- rawDataReader.close();
- rawDataReader = null;
- } catch (IOException ex) {
- // Ignore.
- }
+ try {
+ IOUtils.close(stripeReader, rawDataReader, orcReader);
+ } catch (IOException e) {
+ LOG.warn("Error while closing readers: ", e);
}
+ rawDataReader = null;
Review Comment:
Done!
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java:
##########
@@ -276,11 +275,20 @@ public void unpause() {
@Override
protected Void callInternal() throws IOException, InterruptedException {
- return ugi.doAs(new PrivilegedExceptionAction<Void>() {
- @Override
- public Void run() throws Exception {
- return performDataRead();
+ return ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
+ long startTime = counters.startTimeCounter();
+ try {
+ performDataRead();
+ consumer.setDone();
+ } catch (Throwable t) {
+ consumer.setError(t);
+ trace.dumpLog(LOG);
+ } finally {
+ cleanupReaders();
+ recordReaderTime(startTime);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
