henrib commented on code in PR #5145:
URL: https://github.com/apache/hive/pull/5145#discussion_r1846929909
##########
iceberg/iceberg-catalog/pom.xml:
##########
@@ -32,6 +32,21 @@
<groupId>org.apache.hive</groupId>
<artifactId>hive-iceberg-shading</artifactId>
</dependency>
+ <!-- Intellij dislikes shaded Iceberg: uncomment the following block helps
when coding/debugging -->
+ <!--
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-api</artifactId>
+ <version>${iceberg.version}</version>
+ <optional>true</optional>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-core</artifactId>
+ <version>${iceberg.version}</version>
+ <optional>true</optional>
+ </dependency>
+ -->
Review Comment:
I must ask 'why'? It is very painful to debug when IntelliJ is 'unhappy'
with shaded classes. I think this helps developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
