henrib commented on code in PR #5145: URL: https://github.com/apache/hive/pull/5145#discussion_r1848860408
########## iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveActor.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.hive; + +import java.util.List; +import java.util.Map; +import org.apache.hadoop.hive.metastore.api.Database; +import org.apache.hadoop.hive.metastore.api.LockRequest; +import org.apache.hadoop.hive.metastore.api.LockResponse; +import org.apache.hadoop.hive.metastore.api.ShowLocksRequest; +import org.apache.hadoop.hive.metastore.api.ShowLocksResponse; +import org.apache.hadoop.hive.metastore.api.Table; +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.catalog.Namespace; +import org.apache.thrift.TException; + +/** + * Acts as the Hive client for the HiveCatalog benefit. + */ +public interface HiveActor { Review Comment: I beg to differ. My rough understanding of the code, starting with the HiveCatalog, requires a pool of IMetaStoreClient. The HiveMetaStore (the server part) itself can be instantiated as being local (isMetaStoreRemote=false) but this does not seem to make the client (IMetaStoreClient) any different; the method isMetaStoreRemote() is called only to help during autumn/authz from what I gather. This means that at least any call requires serializing/deserializing Thrift messages and go through the loopback interface (127.0.0.1) for no reason which is a cost we don't have to incur being embedded. Furthermore, this new interface does provide some isolation from HMS and instead of the whole IMetaStoreClient interface, we got a narrow set of identified behaviors required for the Iceberg Catalog only (not the whole legacy that HMS carries). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
