ngsg commented on code in PR #5556: URL: https://github.com/apache/hive/pull/5556#discussion_r1858032082
########## ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java: ########## @@ -220,14 +220,14 @@ public Statistics clone() { } public void addBasicStats(Statistics stats) { - dataSize += stats.dataSize; + dataSize = StatsUtils.safeAdd(dataSize,stats.dataSize); Review Comment: NIT, I think we miss a space between the arguments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org