yiqijiu commented on code in PR #5556:
URL: https://github.com/apache/hive/pull/5556#discussion_r1862281569
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java:
##########
@@ -220,14 +220,14 @@ public Statistics clone() {
}
public void addBasicStats(Statistics stats) {
- dataSize += stats.dataSize;
+ dataSize = StatsUtils.safeAdd(dataSize, stats.dataSize);
numRows += stats.numRows;
Review Comment:
You are right, thank you. I was also hesitant about this. With your
suggestion, it does seem more appropriate to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
