ngsg commented on PR #5560: URL: https://github.com/apache/hive/pull/5560#issuecomment-2499995439
The patch seems reasonable, but I have a little doubt about the behaviour of `StatsSetupConst.setStatsStateForCreateTable`. If I understand correctly, `StatsSetupConst.setStatsStateForCreateTable` does not computes column statistics immediately, but it updates `COLUMN_STATS_ACCURATE`. Could you explain how does `COLUMN_STATS_ACCURATE` gather ColStats or trigger ColStats computation? If this is not related to ColStats computation, then I think it would be better to backport HIVE-20221 into branch-3.1. Also I found that `CreateTableLikeOperation` and `AbstractAddPartitionAnalyzer` also call `StatsSetupConst.setStatsStateForCreateTable` similarly. Maybe we could apply the same fix on them too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
