ngsg commented on PR #5560: URL: https://github.com/apache/hive/pull/5560#issuecomment-2507370912
LGTM with one nit and updating 3 qfile outputs I have checked that 3 qfiles failed because Hive marks all columns as accurate in `COLUMN_STATS_ACCURATE` for newly create TableLikes and Partitions. I think these test qfile verify your patch on `CreateTableLikeOperation` and `AbstractAddPartitionAnalyzer`. I wonder if there exists any incorrect column statistics computation issues which this patch can fix, but I couldn't find such problems so far. The following [link](https://gist.github.com/ngsg/04b8e4e39901891527557143774500c2) contains a query that I used to investigate. It would be appreciated if anyone know and could share an example of incorrect column statistics computation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
