Indhumathi27 commented on code in PR #5568:
URL: https://github.com/apache/hive/pull/5568#discussion_r1870606329


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -1634,7 +1634,10 @@ public static String getPartitionName(Path tablePath, 
Path partitionPath, Set<St
     return result;
   }
 
-  public static String getNormalisedPartitionValue(String partitionValue, 
String type) {
+  public static String getNormalisedPartitionValue(String partitionValue, 
String type, String defaultPartName) {

Review Comment:
   why dont we get and check MetastoreConf.ConfVars.DEFAULTPARTITIONNAME here 
itself, rather than passing from the caller ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to