okumin commented on code in PR #5568:
URL: https://github.com/apache/hive/pull/5568#discussion_r1875773175
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -1636,6 +1637,10 @@ public static String getPartitionName(Path tablePath,
Path partitionPath, Set<St
public static String getNormalisedPartitionValue(String partitionValue,
String type) {
+ if (!NumberUtils.isParsable(partitionValue)) {
+ return partitionValue;
+ }
Review Comment:
I originally thought it could not work when `Double.parseDouble` can not
decode it but `new BigDecimal` can decode it. An example in my mind was a huge
number. Looking at the implementation, now I feel the current implementation
would work
https://github.com/apache/commons-lang/blob/daa63aa595ea39a69e1b44ac23bc50fdcf2afd62/src/main/java/org/apache/commons/lang3/math/NumberUtils.java#L1794-L1810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
