abstractdog commented on code in PR #5559:
URL: https://github.com/apache/hive/pull/5559#discussion_r1873852742
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java:
##########
@@ -280,6 +280,7 @@ public int monitorExecution() {
// best effort
}
console.printError("Execution has failed. stack trace: " +
ExceptionUtils.getStackTrace(e));
+ diagnostics.append(e.getMessage());
Review Comment:
I see, this is an edge where we don't even reach real dag monitoring then
not sure where the diagnostics object is used, but does it make sense to use
the full trace, like:
```
String reportedException = "Execution has failed, stack trace: " +
ExceptionUtils.getStackTrace(e);
console.printError(reportedException);
diagnostics.append(reportedException);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
