zratkai commented on code in PR #5559:
URL: https://github.com/apache/hive/pull/5559#discussion_r1875957100
##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands3.java:
##########
@@ -256,17 +251,17 @@ public void testAcidMetaColumsDecode() throws Exception {
*/
@Test
public void testSdpoBucketed() throws Exception {
- testSdpoBucketed(true, true, 1);
- testSdpoBucketed(true, false, 1);
- testSdpoBucketed(false, true, 1);
- testSdpoBucketed(false, false,1);
-
- testSdpoBucketed(true, true, 2);
- testSdpoBucketed(true, false, 2);
- testSdpoBucketed(false, true, 2);
- testSdpoBucketed(false, false,2);
+ testSdpoBucketed(true, 1);
+ testSdpoBucketed(true, 1);
Review Comment:
There are multiple test cases with the same input parameters, so testing the
same twice. Please eliminate the duplications !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
