DanielZhu58 commented on code in PR #5578:
URL: https://github.com/apache/hive/pull/5578#discussion_r1900577659
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java:
##########
@@ -1395,9 +1395,50 @@ List<ColumnStatistics> getPartitionColumnStatistics(
* @throws InvalidInputException bad input, such as null table or database
name.
*/
boolean deletePartitionColumnStatistics(String catName, String dbName,
String tableName,
Review Comment:
Acknowledged.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java:
##########
@@ -1395,9 +1395,50 @@ List<ColumnStatistics> getPartitionColumnStatistics(
* @throws InvalidInputException bad input, such as null table or database
name.
*/
boolean deletePartitionColumnStatistics(String catName, String dbName,
String tableName,
- String partName, List<String> partVals, String colName, String engine)
- throws NoSuchObjectException, MetaException, InvalidObjectException,
InvalidInputException;
+ String partName, List<String> partVals, String colName, String engine)
+ throws NoSuchObjectException, MetaException, InvalidObjectException,
InvalidInputException;
+
+ /**
+ * Deletes column statistics if present associated with a given db, table,
partition and a list of cols. If
+ * null is passed instead of a colName, stats when present for all columns
associated
+ * with a given db, table and partition are deleted.
+ * @param catName catalog name.
+ * @param dbName database name.
+ * @param tableName table name.
+ * @param partName partition name.
+ * @param partVals partition values.
+ * @param colNames a list of column names.
+ * @param engine engine for which we want to delete statistics
+ * @return Boolean indicating the outcome of the operation
+ * @throws NoSuchObjectException no such partition
+ * @throws MetaException error access the RDBMS
+ * @throws InvalidObjectException error dropping the stats
+ * @throws InvalidInputException bad input, such as null table or database
name.
+ */
+ boolean deletePartitionMultiColumnStatistics(String catName, String dbName,
String tableName,
+ String partName, List<String> partVals, List<String> colNames, String
engine)
+ throws NoSuchObjectException, MetaException, InvalidObjectException,
InvalidInputException;
+ /**
+ * Deletes column statistics in batch if present associated with a given db,
table, partition and a list of cols. If
+ * null is passed instead of a colName, stats when present for all columns
associated
+ * with a given db, table and partition are deleted.
+ * @param catName catalog name.
+ * @param dbName database name.
+ * @param tableName table name.
+ * @param partName partition name.
+ * @param partVals partition values.
+ * @param colNames a list of column names.
+ * @param engine engine for which we want to delete statistics
+ * @return Boolean indicating the outcome of the operation
+ * @throws NoSuchObjectException no such partition
+ * @throws MetaException error access the RDBMS
+ * @throws InvalidObjectException error dropping the stats
+ * @throws InvalidInputException bad input, such as null table or database
name.
+ */
+ boolean deletePartitionColumnStatisticsInBatch(String catName, String
dbName, String tableName,
Review Comment:
Yes, I agree. I think we can merge these 2 methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
