DanielZhu58 commented on code in PR #5578:
URL: https://github.com/apache/hive/pull/5578#discussion_r1901408833
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -7420,6 +7420,64 @@ public boolean delete_partition_column_statistics(String
dbName, String tableNam
return ret;
}
+ @Override
+ public boolean
delete_partition_column_statistics_req(DeletePartitionColumnStatisticsRequest
req) throws TException {
+ String dbName = req.getDb_name();
+ String tableName = req.getTbl_name();
+ List<String> colNames = req.getCol_names();
+ String partName = req.getPart_name();
+ String engine = req.getEngine();
+ dbName = dbName.toLowerCase();
+ String[] parsedDbName = parseDbName(dbName, conf);
+ tableName = tableName.toLowerCase();
+ if (colNames != null) {
+ for (String colName : colNames) {
+ colName = colName.toLowerCase();
+ startFunction("delete_column_statistics_by_partition",": table=" +
+ TableName.getQualified(parsedDbName[CAT_NAME],
parsedDbName[DB_NAME], tableName) +
+ " partition=" + partName + " column=" + colName);
+ }
+ }
+ boolean ret = false, committed = false;
+
+ getMS().openTransaction();
+ try {
+ List<String> partVals = getPartValsFromName(getMS(),
parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName, partName);
Review Comment:
Currently we don't need to delete the stats for multiple partitions, because
currently there is no syntax for the user to drop stats for multiple partitions
in HQL.
And also in the use cases, it's not very common that stats of multiple
adjacent partitions become huge. The user can drop stats of multiple partitions
one by one manually.
I think this partName here is not optional.
In hive_metastore.thrift,
`struct DeletePartitionColumnStatisticsRequest {
1: required string cat_name,
2: required string db_name,
3: required string tbl_name,
4: required string part_name,
5: optional list<string> col_names,
6: required string engine
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
