tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1903648012
##########
standalone-metastore/metastore-tools/metastore-benchmarks/pom.xml:
##########
@@ -189,18 +189,12 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <compilerId>javac-with-errorprone</compilerId>
<forceJavacCompilerUse>true</forceJavacCompilerUse>
</configuration>
<!--
Error Prone integration
-->
<dependencies>
- <dependency>
Review Comment:
@deniskuzZ here are the results of metastore benchmarks in comparison to
jdk8:
[benchmarksdiff.txt](https://github.com/user-attachments/files/18313550/benchmarksdiff.txt)
NOTE: Benchmark - renameTable produces error in case of both jdk8 and jdk17
(it can be mitigated by removing
[Line-526](https://github.com/apache/hive/blob/d824e2f6d79f0b86d04fd9a1b408ef35731e09a3/standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java#L526)
). and ACIDBenchmarks.TestLocking.lock also throws error with respect to clean
up of txns in case of both jdk8 and jdk17 but it still produces results not
sure if this is expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
