okumin commented on PR #5404: URL: https://github.com/apache/hive/pull/5404#issuecomment-2663555919
@akshat0395 I'm willing to merge this one, but I have two challenges. ### The number of changed files is huge This pull request changes 178 files. I manually counted the number of files, which included only nonessential changes. I guess the first and the second ones don't belong to this PR. We would have already merged 40% of this PR if we had separated them. The third one can also be separated. - Add `@SuppressFBWarnings`: 58 - JavaDoc: 21 - Applying Java 17 syntaxes(multiline string, `String#formatted`, pattern matching): 33 ### It is hard to identify why we have to change test results I can see this PR changes various `.q.out`. I see some comments explaining the root cause, such as the new container size, but I don't have an economical way to validate the statements. For example, if we agreed(I'm not confident with the necessity of the changes. BsoBird gave us additional information) with the new container size and extracted them into another PR, we would quickly review and merge that part without doubting any other changes. - Stats - The number of output files - Timezone - Floating Point -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
