ramesh0201 commented on code in PR #5577:
URL: https://github.com/apache/hive/pull/5577#discussion_r1907506231


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java:
##########
@@ -1103,6 +1103,9 @@ private VectorExpression 
getGenericUDFStructField(ExprNodeFieldDesc exprNodeFiel
   private int getStructFieldIndex(ExprNodeFieldDesc exprNodeFieldDesc) throws 
HiveException {
     ExprNodeDesc structNodeDesc = exprNodeFieldDesc.getDesc();
     String fieldName = exprNodeFieldDesc.getFieldName();
+    if (exprNodeFieldDesc.getIsList()) {
+      throw new HiveException("Could not vectorize expression: Vectorizing 
complex type LIST is not supported");
+    }
     StructTypeInfo structTypeInfo = (StructTypeInfo) 
structNodeDesc.getTypeInfo();

Review Comment:
   I was able to reproduce the ClassCastException even without my patch for a 
simpler query that I mentioned below:
   EXPLAIN VECTORIZATION EXPRESSION
   SELECT s5.f16.f18.f19 FROM nested_tbl_1;
   I will be adding this to the list of queries in the same q file below. What 
I identified is that, we have certain nested access queries that were not 
handled well in the vectorization and we need to address that. But there is no 
new failures after our patch here. We can try to address this issue in a 
separate patch if you think it is reasonable idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to