zabetak commented on code in PR #5577:
URL: https://github.com/apache/hive/pull/5577#discussion_r1913857636


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java:
##########
@@ -1103,6 +1103,9 @@ private VectorExpression 
getGenericUDFStructField(ExprNodeFieldDesc exprNodeFiel
   private int getStructFieldIndex(ExprNodeFieldDesc exprNodeFieldDesc) throws 
HiveException {
     ExprNodeDesc structNodeDesc = exprNodeFieldDesc.getDesc();
     String fieldName = exprNodeFieldDesc.getFieldName();
+    if (exprNodeFieldDesc.getIsList()) {
+      throw new HiveException("Could not vectorize expression: Vectorizing 
complex type LIST is not supported");
+    }
     StructTypeInfo structTypeInfo = (StructTypeInfo) 
structNodeDesc.getTypeInfo();

Review Comment:
   The new message is much better than getting a `ClassCastException`. Adding 
vectorized support for this path is outside the scope of this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to