kasakrisz commented on code in PR #5559:
URL: https://github.com/apache/hive/pull/5559#discussion_r1908284042
##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java:
##########
@@ -2450,6 +2435,9 @@ public void testCleanerForTxnToWriteId() throws Exception
{
// Keep an open txn which refers to the aborted txn.
Context ctx = new Context(hiveConf);
HiveTxnManager txnMgr =
TxnManagerFactory.getTxnManagerFactory().getTxnManager(hiveConf);
+ // Txn is not considered committed or aborted until TXN_OPENTXN_TIMEOUT
expires
+ // See MinOpenTxnIdWaterMarkFunction, OpenTxnTimeoutLowBoundaryTxnIdHandler
+ waitUntilAllTxnFinished();
Review Comment:
I have a repro on a slower computer too but I had to set
`metastore.txn.opentxn.timeout` to 5sec. With 2 sec the test passed on the
slower computer and failed on the faster.
Anyway, I added a TODO to revisit this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
