Re: [PR] HIVE-28601: Leverage configurable getPartitions API in HMS to decrease memory footprint in HS2 [hive]

[via GitHub]

armitage420 commented on code in PR #5539:
URL: https://github.com/apache/hive/pull/5539#discussion_r1915348046


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/status/formatter/ShowTableStatusFormatter.java:
##########
@@ -89,7 +93,18 @@ List<Path> getLocations(Hive db, Partition partition, Table 
table) throws HiveEx
     List<Path> locations = new ArrayList<Path>();
     if (table.isPartitioned()) {
       if (partition == null) {
-        for (Partition currPartition : db.getPartitions(table)) {
+      List<Partition> partitions;
+      GetProjectionsSpec getProjectionsSpec = new 
GetPartitionProjectionsSpecBuilder()
+              .addProjectFieldList(Arrays.asList("sd.location")).build();

Review Comment:
   sd is the variable name for our Partition object for StorageDescriptor. The 
very structure was defined in hive_metastore.thrift and then the Partition.java 
file got generated from the same. This is exactly what we are referencing.
   
![image](https://github.com/user-attachments/assets/8b1cb11f-bbb0-49bf-8e4a-3aabbc22d2be)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org