armitage420 commented on code in PR #5539:
URL: https://github.com/apache/hive/pull/5539#discussion_r1915356625
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -4086,6 +4091,37 @@ public List<String> getPartitionNames(String dbName,
String tblName,
return names;
}
+ // get partition names from provided partition values
+ public List<String> getPartitionNames(String dbName, String tblName,
Review Comment:
1. fixed in line 4069
2. setting `max` to the last param results in ambiguous method calls when
public List<String> `getPartitionNames(String dbName, String tblName,
Map<String, String> partSpec, short max)` is called with `partSpec` set to null.
3. Third party users using HS2 can benefit from this in order to get
partition names with just given filter values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
