abstractdog commented on code in PR #5613: URL: https://github.com/apache/hive/pull/5613#discussion_r1923536811
########## ql/src/java/org/apache/hadoop/hive/ql/Driver.java: ########## @@ -558,11 +560,7 @@ private void setTriggerContext(String queryId) { // query info is created by SQLOperation which will have start time of the operation. When JDBC Statement is not // used queryInfo will be null, in which case we take creation of Driver instance as query start time (which is also // the time when query display object is created) - if (driverContext.getQueryInfo() != null) { - queryStartTime = driverContext.getQueryInfo().getBeginTime(); - } else { - queryStartTime = driverContext.getQueryDisplay().getQueryStartTime(); - } + queryStartTime = driverContext.getQueryStartTime(); Review Comment: just a refactor, to move this logic to a separate method, but yeah, the original comment has lost its meaning here, let me move it also and rename if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org