abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1923544375
##########
ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java:
##########
@@ -137,13 +152,26 @@ public void setPlan(QueryPlan plan) {
this.runtimeContext = Utilities.getFirstTezTask(plan.getRootTasks())
.map(TezTask::getRuntimeContext)
.orElse(null);
+ this.queryProperties = plan.getQueryProperties();
}
}
+ public String getQueryType() {
+ return queryType == null ? "UNKNOWN" : queryType;
Review Comment:
a query must have a type under ideal circumstances, and if we failed to
figure out, that's where "UNKNOWN" comes into the picture, whereas ddlType is
not applicable at all for non-DDL queries (so not "unknown", just "nothing"),
does this make sense? do you think it's better to queryType=="" as the dummy
value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
