abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1923852769
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -600,6 +601,11 @@ default void storageHandlerCommit(Properties
commitProperties, Operation operati
throw new UnsupportedOperationException();
}
+ default void storageHandlerCommit(Properties commitProperties, Operation
operation, TaskAttemptContext context)
Review Comment:
1. okay, let me add
2. because of the fact that we write and commit from HS2, where we have no
tez tasks, but we emulate that we have a single writer task that has to be
committed, let me know if you know other ways to achieve the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
