abstractdog commented on code in PR #5613: URL: https://github.com/apache/hive/pull/5613#discussion_r1923845014
########## ql/src/java/org/apache/hadoop/hive/ql/queryhistory/FromDriverContextUpdater.java: ########## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one§ + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.ql.queryhistory; Review Comment: hive history seems to be a different thing: ``` HIVE_SESSION_HISTORY_ENABLED("hive.session.history.enabled", false, "Whether to log Hive query, query plan, runtime statistics etc."), ``` I didn't know about this one, and it's a session level thing instead of a central history logging, which writes to custom txt files, that are not designed to be queried I think https://github.com/apache/hive/blob/bc87c4d96374fcf7489809e1b5125c10254301c1/ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java#L98 ``` histFileName = conf_file_loc + File.separator + "hive_job_log_" + ss.getSessionId() + "_" + Math.abs(randGen.nextInt()) + ".txt"; ``` it might look not very clear to have different *history* packages, however, apparently, we have very different approaches to log/store query-related information, what do you suggest here? honestly, I'm not ready to make any decision about the current HiveHistory part -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
