dengzhhu653 commented on code in PR #5578:
URL: https://github.com/apache/hive/pull/5578#discussion_r1924635760


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -2716,6 +2719,33 @@ boolean deletePartitionColumnStatistics(String catName, 
String dbName, String ta
       String partName, String colName, String engine)
       throws NoSuchObjectException, MetaException, InvalidObjectException, 
TException, InvalidInputException;
 
+  /**
+   * Delete partition level column statistics given dbName, tableName, 
partName and colName, or
+   * all columns in a partition.
+   * @param dbName database name.
+   * @param tableName table name.
+   * @param partName partition name.
+   * @param colNames a list of column name, or null for all columns
+   * @param engine engine, or null for all engines
+   * @return boolean indicating outcome of the operation
+   * @throws NoSuchObjectException no such partition exists
+   * @throws InvalidObjectException error dropping the stats data
+   * @throws MetaException error accessing the RDBMS
+   * @throws TException thrift transport error
+   * @throws InvalidInputException input is invalid or null.
+   */
+  public boolean deletePartitionMultiColumnStatistics(String dbName, String 
tableName, String partName,

Review Comment:
   It's not a good idea to maintain two variant methods just for a single 
purpose, we should leave only one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to