nrg4878 commented on code in PR #5578:
URL: https://github.com/apache/hive/pull/5578#discussion_r1931349812


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -3658,6 +3658,20 @@ public boolean deletePartitionColumnStatistics(String 
catName, String dbName, St
         tableName, partName, colName, engine);
   }
 
+  @Override
+  public boolean deletePartitionMultiColumnStatistics(String dbName, String 
tableName, String partName,

Review Comment:
   I agree with this. We should remove one of them, retain the one that takes 
the Request Object, rename it to something more generic like 
DeleteColumnStatisticsRequest, make the PartitionName optional and use this 
value to determine whether to delete the Table column stats or Partition 
columns stats.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to