abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1925134762
##########
ql/src/java/org/apache/hadoop/hive/ql/QueryInfo.java:
##########
@@ -40,10 +45,17 @@ public QueryInfo(String state, String userName, String
executionEngine, String s
this.userName = userName;
this.executionEngine = executionEngine;
this.beginTime = System.currentTimeMillis();
+ this.beginTimeUTC = Instant.ofEpochMilli(beginTime);
this.sessionId = sessionId;
this.operationId = operationId;
}
+ public static QueryInfo getFromConf(HiveConf conf) {
+ return new QueryInfo("INITIALIZED",
conf.get(DriverContext.DRIVER_DEFAULT_USER_NAME_PROP),
Review Comment:
double-check, hive-exec doesn't depend on hive-service (actually it's other
way around), so QueryInfo cannot have a reference on OperationState...I'm
afraid refactoring this is beyond the scope of this ticket, created jira about
it: https://issues.apache.org/jira/browse/HIVE-28721
##########
ql/src/java/org/apache/hadoop/hive/ql/QueryInfo.java:
##########
@@ -40,10 +45,17 @@ public QueryInfo(String state, String userName, String
executionEngine, String s
this.userName = userName;
this.executionEngine = executionEngine;
this.beginTime = System.currentTimeMillis();
+ this.beginTimeUTC = Instant.ofEpochMilli(beginTime);
this.sessionId = sessionId;
this.operationId = operationId;
}
+ public static QueryInfo getFromConf(HiveConf conf) {
+ return new QueryInfo("INITIALIZED",
conf.get(DriverContext.DRIVER_DEFAULT_USER_NAME_PROP),
Review Comment:
double-checked, hive-exec doesn't depend on hive-service (actually it's
other way around), so QueryInfo cannot have a reference on
OperationState...I'm afraid refactoring this is beyond the scope of this
ticket, created jira about it: https://issues.apache.org/jira/browse/HIVE-28721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
